fix: pass admintools.additionalEnv to create-store and manage-schema containers (#865)#874
Merged
robholland merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
robholland
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This change added
additionalEnv,additionalEnvSecretName, andadditionalEnvConfigMapNamesupport to thecreate-*-storeandmanage-schema-*-storeinit containers inserver-job.yaml.Before the change these were only passed to the
create-*-namespacecontainers.Updated unit tests to assert that additional env are present on all init container types.
Why?
Bug fix: Environment variables set via
admintools.additionalEnvare not inherited by the create-default-store, setup-default-store, and update-default-store init containers.Checklist
Closes [Bug]
admintools.additionalEnvnot being passed tocreate/manage-schemacontainers #865How was this tested:
Updated
helm unittesttest case "includes additional environment variables" inserver_job_test.yamlto cover all init container typesAny docs updates needed?
Bug fix, README already covers this feature.